Messages in this thread | | | From | Grant Likely <> | Date | Tue, 25 Oct 2011 00:04:02 +0200 | Subject | Re: [PATCH] gpio: fix build error in include/asm-generic/gpio.h |
| |
On Fri, Oct 21, 2011 at 1:39 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday 21 October 2011, Hamo wrote: >> Should call the platform-specific __gpio_{get,set}_value >> instead of generic gpio_{get,set}_value >> >> Signed-off-by: Yang Bai <hamo.by@gmail.com> >> --- >> include/asm-generic/gpio.h | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Grant, can you put that into the gpio tree?
I can.
Hamo, next time make sure you cc: the relevant subsystem maintainer (in this case, me) when submitting patches. You can find the maintainer by using ./scripts/get_maintainer.pl, or by looking at the MAINTAINERS file. It is more work for me when I don't receive the patch directly in my inbox.
g.
> >> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h >> index d494001..6acff5d 100644 >> --- a/include/asm-generic/gpio.h >> +++ b/include/asm-generic/gpio.h >> @@ -220,13 +220,13 @@ static inline int gpio_cansleep(unsigned gpio) >> static inline int gpio_get_value_cansleep(unsigned gpio) >> { >> might_sleep(); >> - return gpio_get_value(gpio); >> + return __gpio_get_value(gpio); >> } >> >> static inline void gpio_set_value_cansleep(unsigned gpio, int value) >> { >> might_sleep(); >> - gpio_set_value(gpio, value); >> + __gpio_set_value(gpio, value); >> } >> >> #endif /* !CONFIG_GPIOLIB */ >> -- >> 1.7.1 >> > >
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |