Messages in this thread | | | Date | Mon, 24 Oct 2011 18:07:32 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 11/X] uprobes: x86: introduce xol_was_trapped() |
| |
On 10/24, Srikar Dronamraju wrote: > > > diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm/uprobes.h > > index 1c30cfd..f0fbdab 100644 > > --- a/arch/x86/include/asm/uprobes.h > > +++ b/arch/x86/include/asm/uprobes.h > > @@ -39,6 +39,7 @@ struct uprobe_arch_info { > > > > struct uprobe_task_arch_info { > > unsigned long saved_scratch_register; > > + unsigned long saved_trap_no; > > }; > > #else > > struct uprobe_arch_info {}; > > > one nit > I had to add saved_trap_no to #else part (i.e uprobe_arch_info ).
Yes, thanks, I didn't notice this is for X86_64 only.
And just in case, please feel free to rename/redo/whatever.
Oleg.
| |