lkml.org 
[lkml]   [2011]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/4] MIPS: Add board support for Loongson1B
    Hello Kelvin.

    On 10/24/2011 12:36 PM, Kelvin Cheung wrote:

    [snip]

    > According to datasheet of Loongson 1B, the buffer size in RX/TX
    > descriptor is only 2KB. So the Loongson1B's GMAC could not handle
    > jumbo frames. And the second buffer is useless in this case. Am I
    > right? Is there a better way than ifdef CONFIG_MACH_LOONGSON1 to
    > avoid duplicate code?

    Sorry for my misunderstanding.

    I think you have to use the normal descriptor and remove the enh_desc
    from the platform w/o modifying the driver at all.

    The driver will be able to select/configure all automatically (also jumbo).

    Let me know.

    Note:
    IIRC, there is a bit difference in case of normal descriptors for
    Synopsys databook newer than the 1.91 (I used for testing this mode).
    In any case, I remember that, on some platforms, the normal descriptors
    have been used w/o problems also on these new chip generations.

    Peppe



    \
     
     \ /
      Last update: 2011-10-24 14:21    [W:0.023 / U:91.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site