lkml.org 
[lkml]   [2011]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip/core/rcu 31/55] rcu: Make rcu_implicit_dynticks_qs() locals be correct size
    On Sun, Oct 16, 2011 at 06:43:50PM -0700, Josh Triplett wrote:
    > On Tue, Sep 06, 2011 at 11:00:25AM -0700, Paul E. McKenney wrote:
    > > When the ->dynticks field in the rcu_dynticks structure changed to an
    > > atomic_t, its size on 64-bit systems changed from 64 bits to 32 bits.
    > > The local variables in rcu_implicit_dynticks_qs() need to change as
    > > well, hence this commit.
    >
    > If an atomic_t always holds 32-bits, which it appears to, then shouldn't
    > this use u32 rather than unsigned int?

    The atomic_t definition is "int", and I need "unsigned int" to avoid
    integer overflow.

    But it might make sense to make atomic_t s32, in which case I would
    use u32. I don't feel very strongly about it either way, because "int"
    is also defined to be 32 bits. Maybe I should put such a patch forward
    later on.

    Thanx, Paul



    \
     
     \ /
      Last update: 2011-10-24 14:09    [W:4.063 / U:0.528 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site