Messages in this thread | | | Date | Mon, 24 Oct 2011 13:35:37 +0200 | From | Grant Likely <> | Subject | Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data |
| |
On Mon, Oct 24, 2011 at 05:11:58PM +0800, Shawn Guo wrote: > On Mon, Oct 24, 2011 at 02:26:49PM +0530, Rajendra Nayak wrote: > > On Monday 24 October 2011 02:32 PM, Shawn Guo wrote: > > >Okay, it's wrong then since so many people say it's wrong :) I guess > > >a quick fix would be adding one property in device tree node for > > >matching some unique field in regulator_desc, id, maybe? Mark, any > > >suggestion? > > > > Thats basically what the DT compatible property is for :) > > But adding compatible property will get DT core create 'struct dev' > for each regulator node, while we are trying to avoid that since > regulator core has been doing this.
By design, of_platform_populate() will only go one level deep except if it matches the passed in list of bus compatible properties. Having a compatible property does not necessarily create a struct dev.
That said, I agree with you that a compatible property isn't really needed in the child nodes **if it is defined as part of the parent node's binding**.
g.
| |