lkml.org 
[lkml]   [2011]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] regulator: Add S5M8767 regulator driver
Date
On Sun, Oct 23, 2011 at 06:30 PM , Mark Brown wrote:

> I guess you need an implementation for enable_suspend() (otherwise you
> can't do disable->enable)
Ok, I will add it in the next version.

>
> > + {
> > + .name = "AP 32KHz",
> > + .id = S5M8767_32KHZAP_EN,
> > + .ops = &s5m8767_others_ops,
> > + .type = REGULATOR_VOLTAGE,
> > + .owner = THIS_MODULE,
> > + }, {
> > + .name = "CP 32KHz",
> > + .id = S5M8767_32KHZAP_EN,
> > + .ops = &s5m8767_others_ops,
> > + .type = REGULATOR_VOLTAGE,
> > + .owner = THIS_MODULE,
> > + },
>
> Do these actually share anything with the other regulators? If not then
> I guess it's better to do with the struct clk framework.

OK, I will consider clk framework


> > + dev_warn(&pdev->dev, "Duplicated gpio
> > request"
> > + " for SET3\n");
>
> Please keep the strings on one line (it makes grepping for errors
> easier).

Thanks,
Sangbeom.



\
 
 \ /
  Last update: 2011-10-23 13:03    [W:0.240 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site