Messages in this thread | | | From | Sangbeom Kim <> | Subject | RE: [PATCH] regulator: Add S5M8767 regulator driver | Date | Sun, 23 Oct 2011 19:59:50 +0900 |
| |
On Sun, Oct 23, 2011 at 06:30 PM , Mark Brown wrote:
> I guess you need an implementation for enable_suspend() (otherwise you > can't do disable->enable) Ok, I will add it in the next version.
> > > + { > > + .name = "AP 32KHz", > > + .id = S5M8767_32KHZAP_EN, > > + .ops = &s5m8767_others_ops, > > + .type = REGULATOR_VOLTAGE, > > + .owner = THIS_MODULE, > > + }, { > > + .name = "CP 32KHz", > > + .id = S5M8767_32KHZAP_EN, > > + .ops = &s5m8767_others_ops, > > + .type = REGULATOR_VOLTAGE, > > + .owner = THIS_MODULE, > > + }, > > Do these actually share anything with the other regulators? If not then > I guess it's better to do with the struct clk framework.
OK, I will consider clk framework
> > + dev_warn(&pdev->dev, "Duplicated gpio > > request" > > + " for SET3\n"); > > Please keep the strings on one line (it makes grepping for errors > easier).
Thanks, Sangbeom.
| |