lkml.org 
[lkml]   [2011]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC V2 1/5] debugfs: Add support to print u32 array in debugfs
    On Mon, Oct 24, 2011 at 12:34:04AM +0530, Raghavendra K T wrote:
    > Add debugfs support to print u32-arrays in debugfs. Move the code from Xen to debugfs
    > to make the code common for other users as well.

    You forgot the kerneldoc for the function explaining what it is and how
    to use it, and the EXPORT_SYMBOL_GPL() marking for the global function
    as that's the only way it will be able to be used, right?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-10-24 00:25    [W:0.033 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site