lkml.org 
[lkml]   [2011]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bisected: Massive memory leak in dm-snapshot in 3.1 development introduced
On Sun, 23 Oct 2011 14:44:49 +0100
Alasdair G Kergon <agk@redhat.com> wrote:

> On Sun, Oct 23, 2011 at 12:52:06PM +0300, Linus Torvalds wrote:
> > Mikulas, Alasdair? I see the mempool_free() for the "master job",
> > what about everything else? Does the dm_kcopyd_prepare_callback()
> > perhaps need to do a
> >
> > job->master_job = job;
> >
> > or similar?
>
> If you look at the other place that performs that mempool_alloc, it's
> indeed present there.
>
> Michael - can you test if this solves the problem?
>
> Alasdair
>
> --- a/drivers/md/dm-kcopyd.c
> +++ b/drivers/md/dm-kcopyd.c
> @@ -628,6 +628,7 @@ void *dm_kcopyd_prepare_callback(struct
> dm_kcopyd_client *kc, job->kc = kc;
> job->fn = fn;
> job->context = context;
> + job->master_job = job;
>
> atomic_inc(&kc->nr_jobs);
>
>

Yup, it indeed does.

--
MfG,

Michael Leun



\
 
 \ /
  Last update: 2011-10-23 16:33    [W:0.147 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site