lkml.org 
[lkml]   [2011]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [DRM] Lower the severity of the radeon lockup messages.
On 10/21/2011 10:51 AM, Dave Jones wrote:
> abrt files a lot of bug reports when users get GPU lockups, but there's not really
> enough context to do anything useful with them. Given the lack of GPU context being
> dumped, this patch removes the stack trace, so that abrt ignores the messages.
>
> Signed-off-by: Dave Jones<davej@redhat.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
> index 7fd4e3e..a488b50 100644
> --- a/drivers/gpu/drm/radeon/radeon_fence.c
> +++ b/drivers/gpu/drm/radeon/radeon_fence.c
> @@ -263,7 +263,7 @@ retry:
> */
> if (seq == rdev->fence_drv.last_seq&& radeon_gpu_is_lockup(rdev)) {
> /* good news we believe it's a lockup */
> - WARN(1, "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
> + printk(KERN_WARNING "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
> fence->seq, seq);
> /* FIXME: what should we do ? marking everyone
> * as signaled for now

At the risk of sounding obvious, wouldn't it be better to enhance the
driver to dump out more useful debugging info in this case rather than
just suppressing the ABRT report?


\
 
 \ /
  Last update: 2011-10-22 09:19    [W:0.046 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site