lkml.org 
[lkml]   [2011]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED
    Date
    Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    Cc: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
    Cc: Jayachandran C <jayachandranc@netlogicmicro.com>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/usb/host/ehci-pxa168.c | 2 +-
    drivers/usb/host/ohci-xls.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/host/ehci-pxa168.c b/drivers/usb/host/ehci-pxa168.c
    index ac0c16e..f0b776d 100644
    --- a/drivers/usb/host/ehci-pxa168.c
    +++ b/drivers/usb/host/ehci-pxa168.c
    @@ -304,7 +304,7 @@ static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev)
    hcd->has_tt = 1;
    ehci->sbrn = 0x20;

    - err = usb_add_hcd(hcd, irq, IRQF_SHARED | IRQF_DISABLED);
    + err = usb_add_hcd(hcd, irq, IRQF_SHARED);
    if (err)
    goto err5;

    diff --git a/drivers/usb/host/ohci-xls.c b/drivers/usb/host/ohci-xls.c
    index a3a9c6f..38b6bda 100644
    --- a/drivers/usb/host/ohci-xls.c
    +++ b/drivers/usb/host/ohci-xls.c
    @@ -56,7 +56,7 @@ static int ohci_xls_probe_internal(const struct hc_driver *driver,
    goto err3;
    }

    - retval = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED);
    + retval = usb_add_hcd(hcd, irq, IRQF_SHARED);
    if (retval != 0)
    goto err4;
    return retval;
    --
    1.7.1


    \
     
     \ /
      Last update: 2011-10-22 12:21    [W:0.021 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site