[lkml]   [2011]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 2/5] ext4: ext4_rename should dirty dir_bh with the correct directory
    When ext4_rename performs a directory rename (move), dir_bh is a buffer that is
    modified to update the '..' link in the directory being moved (old_inode).
    However, ext4_handle_dirty_metadata is called with the old parent directory
    inode (old_dir) and dir_bh, which is incorrect because dir_bh does not belong
    to the parent inode. Fix this error.

    Signed-off-by: Darrick J. Wong <>
    fs/ext4/namei.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
    index 310b356..6d3fab4 100644
    --- a/fs/ext4/namei.c
    +++ b/fs/ext4/namei.c
    @@ -2530,7 +2530,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
    PARENT_INO(dir_bh->b_data, new_dir->i_sb->s_blocksize) =
    BUFFER_TRACE(dir_bh, "call ext4_handle_dirty_metadata");
    - retval = ext4_handle_dirty_metadata(handle, old_dir, dir_bh);
    + retval = ext4_handle_dirty_metadata(handle, old_inode, dir_bh);
    if (retval) {
    ext4_std_error(old_dir->i_sb, retval);
    goto end_rename;

     \ /
      Last update: 2011-10-21 23:21    [W:4.021 / U:0.292 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site