Messages in this thread | | | From | Kay Sievers <> | Date | Thu, 20 Oct 2011 18:16:04 +0200 | Subject | Re: [PATCH 02/10] block: fix genhd refcounting in blkio_policy_parse_and_set() |
| |
On Thu, Oct 20, 2011 at 18:11, Tejun Heo <tj@kernel.org> wrote: > I think this is essentially a bug. If you have something like "dev = > find_and_get(); put(dev); return dev != NULL;", it's a pretty good > indication something is pretty screwed there, so unless someone > screams really loud, I think I'm gonna push for removal of the > feature.
Matching on unpredictable dev_t inside the kernel or in userspace is a serious bug. We can't do anything like that ever on a modern system, these times are long over.
Yes, please get rid of this misguided logic, nobody should get the impression that this can ever work.
Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |