Messages in this thread | | | Date | Thu, 20 Oct 2011 17:06:05 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection |
| |
On Wed, Oct 19, 2011 at 05:19:06PM -0400, David Rientjes wrote: > On Wed, 19 Oct 2011, Borislav Petkov wrote: > > > > That wouldn't catch an offline cpuid, you probably want cpu_online(val)? > > > > Good catch, thanks. > > > > So I'm looking at <arch/x86/kernel/cpuid.c> which is how the validity of > > a cpu value should be tested properly, IMHO: > > > > static int cpuid_open(struct inode *inode, struct file *file) > > { > > ... > > > > if (cpu >= nr_cpu_ids || !cpu_online(cpu)) > > return -ENXIO; /* No such CPU */ > > ... > > Right, the comment for cpumask_test_cpu(), which cpu_online() really is, > wants a cpu < nr_cpu_ids.
Fixed, thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |