lkml.org 
[lkml]   [2011]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 00/17][RFC] ktest updates for v3.2
    Date
    Steven Rostedt <rostedt <at> goodmis.org> writes:

    >
    > As it is getting close to the merge window. I want to post the
    > patches I will be pushing to Linus. I know most people don't even
    > use this, but I figured I would show what's changed since the last
    > release.
    >
    > This is also the code base I will be using for my tutorial at
    > LinuxCon EU.
    >

    Hmm, I have a couple comments.

    First, all the new additions such as IF, ELSE, DEFINED, INCLUDE are starting to
    reinvent 'make' inside of ktest.pl. At the point those constructs were needed,
    I'd probably have gone the opposite way. I would have ripped any special parsing
    out of ktest.pl, reducing it to only read simple key=value pairs. Then I would
    have renamed sample.conf to Makefile and tweaked it for the syntax. Makefile
    would then include Makefile.ktest, which would be where users can go to town
    with their own custom "configs" using all the make constructs. It would also
    have a couple targets, ktest.conf and ktest. ktest.conf would output the
    generated, simple key=value config. ktest would run ktest.pl with the generated
    config passed to it, either through a file or by using environment variables.

    My other comment is that it appears a few of the patches from my August
    series[*] got dropped. Please keep in mind that without the CONSOLE_RESET_TIME
    patch in that series ktest doesn't work with virtual machine consoles, so
    afaict, it's a must have. Also the RERUN patch was necessary for me to use ktest
    on my last bisect, since the problem was during boot. Indeed, all the patches in
    that series were useful at some point, so I'd appreciate if they were all
    integrated.

    Drew

    [*] http://thread.gmane.org/gmane.linux.kernel/1178676



    \
     
     \ /
      Last update: 2011-10-20 16:53    [W:0.039 / U:0.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site