lkml.org 
[lkml]   [2011]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFCv4 PATCH 2/6] ivtv: only start streaming in poll() if polling for input.
From
Date
On Thu, 2011-09-29 at 09:44 +0200, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

FWIW:

Acked-by: Andy Walls <awalls@md.metrocast.net>

-Andy


> ---
> drivers/media/video/ivtv/ivtv-fileops.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
> index 38f0522..a931ecf 100644
> --- a/drivers/media/video/ivtv/ivtv-fileops.c
> +++ b/drivers/media/video/ivtv/ivtv-fileops.c
> @@ -744,8 +744,9 @@ unsigned int ivtv_v4l2_dec_poll(struct file *filp, poll_table *wait)
> return res;
> }
>
> -unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table * wait)
> +unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table *wait)
> {
> + unsigned long req_events = poll_requested_events(wait);
> struct ivtv_open_id *id = fh2id(filp->private_data);
> struct ivtv *itv = id->itv;
> struct ivtv_stream *s = &itv->streams[id->type];
> @@ -753,7 +754,8 @@ unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table * wait)
> unsigned res = 0;
>
> /* Start a capture if there is none */
> - if (!eof && !test_bit(IVTV_F_S_STREAMING, &s->s_flags)) {
> + if (!eof && !test_bit(IVTV_F_S_STREAMING, &s->s_flags) &&
> + (req_events & (POLLIN | POLLRDNORM))) {
> int rc;
>
> mutex_lock(&itv->serialize_lock);




\
 
 \ /
  Last update: 2011-10-02 14:13    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog