Messages in this thread | | | Date | Wed, 19 Oct 2011 08:44:01 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC PATCH] x86: Add a sanity test of x86 decoder |
| |
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> >> +static void dump_stream(FILE *fp, const char *msg, struct insn *insn) > >> +{ > >> + int i; > >> + fprintf(fp, "%s:\n code:", msg); > > > > missing newline. > > This prints a header of code sequence, so that we'll see a > message like below;
I mean, it's missing the standard newline between local variable(s) and the first statement:
static void dump_stream(FILE *fp, const char *msg, struct insn *insn) { int i;
fprintf(fp, "%s:\n code:", msg); [...]
We do this for readability.
Thanks,
Ingo
| |