Messages in this thread | | | Subject | Re: [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver | From | Joe Perches <> | Date | Wed, 19 Oct 2011 15:59:18 -0700 |
| |
On Thu, 2011-10-20 at 00:21 +0200, Francois Romieu wrote: > cloud.ren@atheros.com <cloud.ren@atheros.com> : > > diff --git a/drivers/net/ethernet/atheros/alx/alc_cb.c b/drivers/net/ethernet/atheros/alx/alc_cb.c > [...]
A bunch of good style comments.
> > + hw->autoneg_advertised = (ALX_LINK_SPEED_1GB_FULL | > > + ALX_LINK_SPEED_10_HALF | > > + ALX_LINK_SPEED_10_FULL | > > + ALX_LINK_SPEED_100_HALF | > > + ALX_LINK_SPEED_100_FULL); > Parenthesis abuse.
Maybe. I use parenthesis too, but not the trailing | alignment. emacs does leading alignment nicely when you use an open paren.
| |