lkml.org 
[lkml]   [2011]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection
On Wed, 19 Oct 2011, Borislav Petkov wrote:

> > That wouldn't catch an offline cpuid, you probably want cpu_online(val)?
>
> Good catch, thanks.
>
> So I'm looking at <arch/x86/kernel/cpuid.c> which is how the validity of
> a cpu value should be tested properly, IMHO:
>
> static int cpuid_open(struct inode *inode, struct file *file)
> {
> ...
>
> if (cpu >= nr_cpu_ids || !cpu_online(cpu))
> return -ENXIO; /* No such CPU */
> ...

Right, the comment for cpumask_test_cpu(), which cpu_online() really is,
wants a cpu < nr_cpu_ids.


\
 
 \ /
  Last update: 2011-10-19 23:21    [W:1.660 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site