Messages in this thread | | | Date | Wed, 19 Oct 2011 15:16:00 -0200 | From | Flavio Leitner <> | Subject | Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default |
| |
On Mon, 17 Oct 2011 17:52:38 -0400 (EDT) David Miller <davem@davemloft.net> wrote:
> From: Dan McGee <dpmcgee@gmail.com> > Date: Mon, 17 Oct 2011 15:25:24 -0500 > > > If these are truly debug options, they should be turned off by default > > and can be tweaked if necessary. Fix one usage of the flag to use #if > > instead of #ifdef so defining to zero is acceptable. > > > > Signed-off-by: Dan McGee <dpmcgee@gmail.com> > > Illegal window shrinks are a serious issue, and the fact that everyone > will see those messages by default and sometimes report them has been > tremendously useful. >
Agreed. I recently got bug report because of that message. It is useful and doesn't disturbe when network is fine, so please don't remove it.
fbl
| |