Messages in this thread | | | Date | Wed, 19 Oct 2011 10:04:06 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH] XEN_DOMAIN_MEMORY options. |
| |
> > >>>What's the rationale? > > >>> > > >>> J > > >> > > >>The first patch is actually bug fix. You can not define just "int" > > >>without description in Kconfig. As the result this option will not be > > >>visible in menuconfig. Even if you will change it in .config make > > >>oldconfig will set it up for default value. So you need to add any > > >>description to it as all others int options have. > > > > > >No, that was deliberate, because I don't really think there's a need to > > >change it. > > > > > > > From that point of view it's not clear why this option is still in Kconfig? > > Well, we do need to alter it to 512GB. Actually - putting that extra > burden on initial pagetables to reserve extra 384 pages might be a bit > too much. Even thought later on we reclaim it if we do not use it.
Jeremy, without that change, you cannot specify
CONFIG_XEN_MAX_DOMAIN_MEMORY=512
if the distro desires to do so. Well, you can write it in the .config, but the moment you compile, the oldconfig rewrites it to 128.
| |