Messages in this thread | | | Date | Wed, 19 Oct 2011 12:26:30 +0200 | From | Wolfram Sang <> | Subject | Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch |
| |
> Sorry, I missed one detail. This warning is firing on every patch including > any I pull off mailing lists or produce with git format-patch
So, I assume you have a directory named 'b' in the kernel-root-dir?
The p1-detection is heuristic and can always be fooled, so I don't think extending the logic will help. If too many users think it is annoying, it may be better to remove it. I do think, however, that it might help users sending in their first patches, so I'd prefer to keep it. Experienced users have the option to use something like "--ignore PATCH_PREFIX" in their .checkpatch.conf. I vote for improving the error message but won't oppose a removal if that is what is wanted.
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature]
| |