lkml.org 
[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch
From
Date
On Tue, 2011-10-18 at 16:44 -0700, David Rientjes wrote:
> On Tue, 18 Oct 2011, Jonathan Cameron wrote:
> > This started happening when I run checkpatch on pretty much anything.
> > triggered by the b in this snipped for example
> > diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
> > index 3f8d0af..62dc2a8 100644
> > --- a/arch/arm/mach-pxa/stargate2.c
> > +++ b/arch/arm/mach-pxa/stargate2.c
> > @@ -54,6 +54,8 @@
> > #include <linux/mfd/da903x.h>
> > Anyone else seeing this or have a clue what the heck is going on?

It's done this since:

$ git log -1 1e85572697b348b1a126520349a29654f2ae6a12
commit 1e85572697b348b1a126520349a29654f2ae6a12
Author: Wolfram Sang <w.sang@pengutronix.de>
Date: Tue Jan 6 14:41:24 2009 -0800

checkpatch: Add warning for p0-patches

Some people work internally with -p0-patches which has the danger that one
forgets to convert them to -p1 before mainlining. Bitten myself and seen
p0-patches in mailing lists occasionally, this patch adds a warning to
checkpatch.pl in case a patch is -p0. If you really want, you can fool
this check to generate false positives, this is why it just spits a
warning. Making the check 100% proof is trickier than it looks, so let's
start with a version which catches the cases of real use.

[apw@canonical.com: update message language, handle null prefix, add tests]
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

I've always ignored it.




\
 
 \ /
  Last update: 2011-10-19 02:03    [from the cache]
©2003-2011 Jasper Spaans