[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH -V7 25/26] ext4: Implement rich acl for ext4
    On 2011-10-18, at 9:33 AM, Aneesh Kumar K.V wrote:
    > From: "Aneesh Kumar K.V" <>
    > Support the richacl permission model in ext4. The richacls are stored
    > in "system.richacl" xattrs.This need to be enabled by tune2fs or during
    > mkfs.ext4

    It isn't clear from your commit comment or the code what needs to be enabled by tune2fs or mkfs.ext4. Please list the specific ext4 feature
    that needs to be enabled.

    > +#ifdef CONFIG_EXT4_FS_RICHACL
    > +#define EXT4_IS_RICHACL(inode) IS_RICHACL(inode)

    > +#else /* CONFIG_FS_EXT4_RICHACL */
    > +
    > +#define EXT4_IS_RICHACL(inode) (0)

    It is a bit confusing that you are using both EXT4_IS_RICHACL() and
    IS_RICHACL() in this code. Initially I thought EXT4_IS_RICHACL() was
    checking an ext4-specific inode flag, but it seems that it is instead
    conditional upon the configure flags.

    It looks like it should be possible to use EXT4_IS_RICHACL() in all
    of the code, since the richacl-specific code will not be compiled

    Cheers, Andreas

     \ /
      Last update: 2011-10-18 20:43    [W:0.021 / U:0.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site