Messages in this thread | | | Subject | Re: [PATCH] Fix guest memory leak and panic | From | Ian Campbell <> | Date | Tue, 18 Oct 2011 11:50:55 +0100 |
| |
On Tue, 2011-10-18 at 11:46 +0100, Krishna Kumar2 wrote: > Ian Campbell <Ian.Campbell@citrix.com> wrote on 10/18/2011 03:17:11 PM: > > > > I think the best thing might be to remove the additional ref taking > from > > > the setter function and audit the previous changes to ensure they > > > conform. I'll do that right away and post a fixup patch ASAP. > > > > Sigh, only one out of the ten callers of (__)skb_frag_set_page expects > > skb_frag_set_page to take a new reference. I think that's pretty > > comprehensive evidence that the current behaviour is unexpected and > > wrong. > > Looks good!
Thanks.
> Does it make sense to commit both of these patches? The > reason being - my patch becomes a cleanup of set_skb_frag() > in virtio_net driver.
I think your patch remains a valid cleanup but I don't maintain that code.
Ian.
| |