Messages in this thread | | | From | Grant Likely <> | Date | Mon, 17 Oct 2011 15:07:47 -0600 | Subject | Re: [PATCH] gpio/samsung: Complain loudly if we don't know the SoC |
| |
On Mon, Oct 17, 2011 at 3:04 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > If we don't know the SoC type then we won't add any chips which is rather > unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of > different subsystems. Logging at least provides a hint to the user as to > what's gone wrong. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Be Bolder! May as well use WARN() and be really obnoxious. :-)
g.
> --- > drivers/gpio/gpio-samsung.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c > index 8baa946..90455de 100644 > --- a/drivers/gpio/gpio-samsung.c > +++ b/drivers/gpio/gpio-samsung.c > @@ -2495,6 +2495,9 @@ static __init int samsung_gpiolib_init(void) > s5p_register_gpioint_bank(IRQ_GPIO_XA, 0, IRQ_GPIO1_NR_GROUPS); > s5p_register_gpioint_bank(IRQ_GPIO_XB, IRQ_GPIO1_NR_GROUPS, IRQ_GPIO2_NR_GROUPS); > #endif > + } else { > + pr_crit("Unknown SoC in gpio-samsung, no GPIOs added\n"); > + return -ENODEV; > } > > return 0; > -- > 1.7.6.3 > >
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |