lkml.org 
[lkml]   [2011]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Date
James Morris <jmorris@namei.org> wrote:

> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > + MPI a;
> > +
> > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
>
> Generally, typedef structs are frowned upon in the kernel. I'd prefer to
> see this (and any others) changed to a normal type.

In this case, however, it makes it easier to compare back to the original
code.

David


\
 
 \ /
  Last update: 2011-10-17 17:55    [W:1.846 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site