Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1) | Date | Mon, 17 Oct 2011 16:50:51 +0100 |
| |
James Morris <jmorris@namei.org> wrote:
> > +MPI mpi_alloc(unsigned nlimbs) > > +{ > > + MPI a; > > + > > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL); > > Generally, typedef structs are frowned upon in the kernel. I'd prefer to > see this (and any others) changed to a normal type.
In this case, however, it makes it easier to compare back to the original code.
David
| |