lkml.org 
[lkml]   [2011]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Driver for Primax keyboards violating USB HID spec
On Fri, 14 Oct 2011, Terry Lambert wrote:

> Primax keyboards with the issue this driver addresses report modifier
> keys as in band key events instead of as out of band modifier bits,
> resulting in the modifier keys generating key up events immediately
> before the keys they are intended to modify. This driver rewrites
> the raw report data from such keyboards into USB HID 1.11 compliant
> report data. It only matches the USB vendor and product IDs for the
> keyboard it has been tested on. Since there are several keyboards,
> notably a number of laptops and folding USB keyboards known to have
> similar unresolved problem reports, the list is expected to grow.
>
> Signed-off-by: Terry Lambert <tlambert@chromium.org>
> ---
> drivers/hid/Kconfig | 8 +++
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-core.c | 1 +
> drivers/hid/hid-ids.h | 3 +
> drivers/hid/hid-primax.c | 117 ++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 130 insertions(+), 0 deletions(-)
> create mode 100644 drivers/hid/hid-primax.c
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1130a89..a097e17 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -441,6 +441,14 @@ config HID_PICOLCD_LEDS
> ---help---
> Provide access to PicoLCD's GPO pins via leds class.
>
> +config HID_PRIMAX
> + tristate "Primax non-fully HID-compliant devices" if EXPERT
> + depends on USB_HID
> + default !EXPERT

I have removed thi 'EXPERT' dependency (please see changelog of commit
73d5e8f77e8 for rationale behind that) and applied. Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2011-10-17 17:15    [W:0.552 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site