Messages in this thread | | | Date | Mon, 17 Oct 2011 16:10:22 +0200 | Subject | Re: [PATCH v3] dmaengine: add CSR SiRFprimaII DMAC driver | From | Linus Walleij <> |
| |
On Mon, Oct 17, 2011 at 3:57 PM, Vinod Koul <vinod.koul@intel.com> wrote:
>> + if (sdesc->cyclic) { >> + writel((1 << cid) | 1 << (cid + 16) | >> + readl_relaxed(sdma->base + SIRFSOC_DMA_CH_LOOP_CTRL), >> + sdma->base + SIRFSOC_DMA_CH_LOOP_CTRL); >> + schan->happened_cyclic = schan->completed_cyclic = 0; >> + } > > any reason why we have mixed use of writel_relaxes and writel? > Shouldn't all the DMA register writes be done only using writel?
We has a lengthy discussion on the subject here: http://marc.info/?l=linux-arm-kernel&m=130588591415130&w=2
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |