Messages in this thread | | | Date | Sun, 16 Oct 2011 11:28:15 -0700 | From | Sukadev Bhattiprolu <> | Subject | Re: [PATCH 1/4] TTY: drop driver reference in tty_open fail path |
| |
Jiri Slaby [jslaby@suse.cz] wrote: | When tty_driver_lookup_tty fails in tty_open, we forget to drop a | reference to the tty driver. This was added by commit 4a2b5fddd5 (Move | tty lookup/reopen to caller). | | Fix that by adding tty_driver_kref_put to the fail path.
Arg. Sorry about that. Thanks for spotting/fixing it.
| | I will refactor the code later. This is for the ease of backporting to | stable. | | Introduced-in: v2.6.28-rc2 | Signed-off-by: Jiri Slaby <jslaby@suse.cz> | Cc: stable@kernel.org | Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com> | Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> | Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
| |