lkml.org 
[lkml]   [2011]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] acerhdf: Add support for new hardware
Date
Borislav Petkov writes:

> On Sun, Oct 16, 2011 at 01:28:11AM +0200, Peter Feuerer wrote:
>> Borislav Petkov writes:
>> >On Fri, Oct 14, 2011 at 11:43:34PM +0200, Peter Feuerer wrote:
>> >>From: Peter Feuerer <peter@piie.net>
>> >>
>> >>Add support for new hardware:
>> >>Acer Aspire LT-10Q/531/751/1810/1825,
>> >>Acer Travelmate 7730,
>> >>Packard Bell ENBFT/DOTVR46
>> >>
>> >>To prevent from hardware defects, the default temperature values have been
>> >>decreased.
>> >
>> >do you have some actual bug reports stating that the original
>> >temperature values were causing hw defects?
>>
>> Fortunately not. But due to new supported hardware, of which I don't
>> know the actual temperature limits of processor, harddisk and other
>> components, it just feels safer with this lower settings.
>>
>> Another point is, that you need to have the "kernelmode=1" option
>> when loading the module to enable fan control. When searching the
>> internet for acerhdf tutorials, you see, everybody not only setting
>> kernelmode=1 but also setting the fanon and fanoff variables. So I
>> think it won't change anything for most people.
>>
>> Furthermore seems like kernel and userspace tools have been improved
>> to work more efficient and my netbook doesn't get so hot anymore,
>> for me it stays most of the time at about 50 degree when doing
>> office stuff and surfing.
>
> Ok, good. Sounds to me like this above should be the commit message
> instead of the one sentence you had before because it explains much
> better why you're doing what you're doing with the patch.
>
> Also, the "add support" part should be another patch because
> conceptually it doesn't belong with the temperature changes.

Okay, will split the patches and resend the series.

Thanks a lot
kind regards,
--peter;


\
 
 \ /
  Last update: 2011-10-16 11:41    [W:0.063 / U:6.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site