[lkml]   [2011]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/9] mm: alloc_contig_freed_pages() added
On Sun, 16 Oct 2011 10:01:36 +0200 "Michal Nazarewicz" <> wrote:

> Still, as I think of it now, maybe alloc_contig_free_range() would be
> better?

Nope. Of *course* the pages were free. Otherwise we couldn't
(re)allocate them. I still think the "free" part is redundant.

What could be improved is the "alloc" part. This really isn't an
allocation operation. The pages are being removed from buddy then
moved into the free arena of a different memory manager from where they
will _later_ be "allocated".

So we should move away from the alloc/free naming altogether for this
operation and think up new terms. How about "claim" and "release"?
claim_contig_pages, claim_contig_range, release_contig_pages, etc?
Or we could use take/return.

Also, if we have no expectation that anything apart from CMA will use
these interfaces (?), the names could/should be prefixed with "cma_".

 \ /
  Last update: 2011-10-16 10:31    [W:0.071 / U:0.720 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site