lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v3 3/8] ASoC: da7210: Add support for line out and DAC
On Fri, Oct 14, 2011 at 04:34:05PM +0530, Ashish Chavan wrote:

> + /* Enable Line out amplifiers */
> + snd_soc_write(codec, DA7210_OUT1_L, DA7210_OUT1_L_EN);
> + snd_soc_write(codec, DA7210_OUT1_R, DA7210_OUT1_R_EN);
> + snd_soc_write(codec, DA7210_OUT2, DA7210_OUT2_EN |
> + DA7210_OUT2_OUTMIX_L | DA7210_OUT2_OUTMIX_R);
> +

So, part of the reason I was complaining about you having the DAPM
conversion patch last is that in a driver using DAPM I'd really not
expect to see code like this which open codes register writes to enable
outputs, I'd expect the enables to be being done using DAPM.


\
 
 \ /
  Last update: 2011-10-14 21:17    [W:0.023 / U:11.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site