Messages in this thread Patch in this message | | | Date | Fri, 14 Oct 2011 19:00:47 +0200 | From | Thomas Jarosch <> | Subject | [perf PATCH] Fix possible unterminated readlink() result buffer |
| |
No need to do "buf[len] = '\0';" since the buffer is allocated with zalloc().
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> --- tools/perf/util/header.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index b6c1ad1..1a1c026 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -267,7 +267,7 @@ int build_id_cache__remove_s(const char *sbuild_id, const char *debugdir) if (access(linkname, F_OK)) goto out_free; - if (readlink(linkname, filename, size) < 0) + if (readlink(linkname, filename, size-1) < 0) goto out_free; if (unlink(linkname)) -- 1.7.6.4
| |