Messages in this thread | | | Date | Fri, 14 Oct 2011 18:56:04 +0200 | From | Borislav Petkov <> | Subject | Re: WARNING: at arch/x86/kernel/apic/apic.c:1239 setup_local_APIC+... |
| |
On Fri, Oct 14, 2011 at 09:55:16AM -0400, Borislav Petkov wrote: > So, in the end, and AFAICR, the warning triggers because we're comparing > logical APIC IDs from the APIC Logical Destination Register (0xD0) which > have been assigned by BIOS with "1 << cpu" shifted values which wrap on > 32-bit. > > I'd very much like to know why?
Update: upon a second thought, we think we know why: The WARN_ON cannot stomach the switch to bigsmp apic because, on the one hand, bigsmp_init_apic_ldr() "normalizes" the APIC ids by using the BIOS values (x86_bios_cpu_apicid) but OTOH, x86_cpu_to_logical_apicid contains the early percpu value which got assigned by the default apic, i.e. the shifting thing as it is spec'ed for the LDR register.
So, the way we see it, the WARN_ON should know whether we switched apics or should be removed completely. Btw, why was it added in the first place, the commit message doesn't quite explain why.
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |