lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [GIT PULL] Queue free fix (was Re: [PATCH] block: Free queue resources at blk_release_queue())
From
Date
On Thu, 2011-10-13 at 15:09 +0200, Steffen Maier wrote:
> This fix also went into 3.0.5 via
> http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=blob;f=releases/3.0.5/block-free-queue-resources-at-blk_release_queue.patch
> (originated at http://marc.info/?l=linux-scsi&m=131669751909474&w=2 and
> http://marc.info/?l=linux-scsi&m=131669414205696&w=2)
>
> However, it seems we still have a use-after-free bug, now causing the
> following oops with kernel 3.0.6 when removing paths to storage while
> generating load on device-mapper multipath disks:
>
> > Unable to handle kernel pointer dereference at virtual kernel address 6b6b6b6b6b6b6000
> > Oops: 0038 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> > Modules linked in: iptable_filter ip_tables x_tables dm_round_robin sunrpc qeth_l3 binfmt_misc dm_multipath scsi_dh dm_mod ipv6 qeth ccwgroup [last unloaded: scsi_wait_scan]
> > CPU: 1 Not tainted 3.0.6-50.x.20111006-s390xdefault #1
> > Process blast.LzS_64_SL (pid: 26613, task: 0000000063e2a398, ksp: 0000000064de3560)
> > Krnl PSW : 0704100180000000 000000000048a038 (scsi_print_command+0x44/0xf8)
> > R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:1 PM:0 EA:3
> > Krnl GPRS: 000000000000006b 6b6b6b6b6b6b6b6b 000000006717f800 000000000094f2e0
> > 000000000061242e 000000000062bd88 0000000066fb90d8 0000000065391ad7
> > 000000006717f800 000000006717f800 000000006716a090 000000006717f800
> > 0000000000000004 0000000000672f88 0000000064de3838 0000000064de3808
> > Krnl Code: 000000000048a026: f0b80004ebbf srp 4(12,%r0),3007(%r14),8
> > 000000000048a02c: f0a0000407f4 srp 4(11,%r0),2036,0
> > 000000000048a032: e31020800004 lg %r1,128(%r2)
> > >000000000048a038: e31010b00004 lg %r1,176(%r1)
> > 000000000048a03e: b9020011 ltgr %r1,%r1
> > 000000000048a042: a7840032 brc 8,48a0a6
> > 000000000048a046: e33020000004 lg %r3,0(%r2)
> > 000000000048a04c: c04000182f4c larl %r4,78fee4
> > Call Trace:
> > ([<000000006717f800>] 0x6717f800)
> > [<0000000000487f28>] scsi_log_send+0xf0/0x130
> > [<000000000048824c>] scsi_dispatch_cmd+0xc8/0x4bc
> > [<0000000000490694>] scsi_request_fn+0x3b8/0x480

Correct me if I'm wrong, but this seems to be saying that struct
scsi_cmnd was used after free. This looks to be a different problem
because the command has a separate refcounting model which wasn't
impacted by the change ... it could be we've just exposed yet another
refcounting problem outside of the queue one.

If I had to guess, I'd say a bio got cloned with a SCSI command already
attached, but the ref count on the SCSI command wasn't correctly
adjusted.

James




\
 
 \ /
  Last update: 2011-10-14 18:05    [W:0.121 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site