lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] mtd: rename the redboot module to RedBoot
    From
    Date
    On Mon, 2011-10-03 at 22:23 -0700, Andres Salomon wrote:
    > parse_mtd_partitions takes a list of partition types; if the driver
    > isn't loaded, it attempts to load it, and then it grabs the partition
    > parser. For redboot, the module name is "redboot.ko", while the parser
    > name is "RedBoot". Since modprobe is case-sensitive, attempting to
    > modprobe "RedBoot" will never work. I suspect the embedded systems that
    > make use of redboot just always manually loaded redboot prior to loading
    > their specific nand chip drivers (or statically compiled it in).
    >
    > Alternatives include renaming the parser to "redboot", changing
    > parse_mtd_partitions to accept pairs of strings, or changing modprobe
    > to be case-insensitive. Renaming the module seems like the easy,
    > obvious solution. :)
    >
    > Signed-off-by: Andres Salomon <dilinger@queued.net>
    > ---
    > drivers/mtd/Makefile | 2 +-
    > drivers/mtd/RedBoot.c | 315 +++++++++++++++++++++++++++++++++++++++++++++++++
    > drivers/mtd/redboot.c | 315 -------------------------------------------------
    > 3 files changed, 316 insertions(+), 316 deletions(-)
    > create mode 100644 drivers/mtd/RedBoot.c
    > delete mode 100644 drivers/mtd/redboot.c

    Could you please use MODULE_ALIAS(RedBoot) instead?

    --
    Best Regards,
    Artem Bityutskiy



    \
     
     \ /
      Last update: 2011-10-14 10:59    [W:3.433 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site