Messages in this thread | | | Date | Fri, 14 Oct 2011 01:35:52 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] Driver for Primax keyboards violating USB HID spec |
| |
On Thu, 13 Oct 2011, Terry Lambert wrote:
> Primax keyboards with the issue this driver addresses report modifier > keys as in band key events instead of as out of band modifier bits, > resulting in the modifier keys generating key up events immediately > before the keys they are intended to modify. This driver rewrites > the raw report data from such keyboards into USB HID 1.11 compliant > report data. It only matches the USB vendor and product IDs for the > keyboard it has been tested on. Since there are several keyboards, > notably a number of laptops and folding USB keyboards known to have > similar unresolved problem reports, the list is expected to grow. > > Signed-off-by: Terry Lambert <tlambert@chromium.org>
Terry,
thanks for the patch.
[ ... snip ... ] > +static int px_input_mapping(struct hid_device *hid, struct hid_input *hi, > + struct hid_field *field, struct hid_usage *usage, > + unsigned long **bit, int *max) > +{ > + struct px_device *px = hid_get_drvdata(hid); > + > + px->input_primax = hi->input; > + > + /* Remap keys, if necesssary, here */ > + > + return 0; > +}
I fail to see the point of this routine ... ?
Otherwise, the patch seems fine.
Thanks,
-- Jiri Kosina SUSE Labs
| |