Messages in this thread | | | Date | Fri, 14 Oct 2011 00:34:14 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read |
| |
On Fri, Oct 14, 2011 at 07:29:33AM +0800, Axel Lin wrote:
> I check the regmap code, it seems cache_bypsss is only set > if map->cache_type == REGCACHE_NONE or by regcache_cache_bypass().
That's in regmap. Any ASoC drivers which haven't been converted to directly use regmap will still use the ASoC copy of the cache code.
> + regcache_cache_bypass(codec->control_data, true); > + for (i = 0 ; i < codec->driver->reg_cache_size ; i += step) { > + regmap_read(codec->control_data, i, &val); > + cache[i] = val; > + } > + regcache_cache_bypass(codec->control_data, false);
This is what a driver which uses regmap directly should do.
| |