Messages in this thread | | | Date | Thu, 13 Oct 2011 17:51:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read |
| |
On Thu, Oct 13, 2011 at 03:22:55PM +0800, Axel Lin wrote: > codec->hw_read is broken now, let's covert to regmap_read. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
I'd rather not fix these like this because when we convert these drivers to use regmap directly it won't be quite so obvious what's going on and we'll easily introduce bugs where we start using the cached values from a regmap level cache.
Probably the best thing here is to convert all these drivers to use cache_bypass to read directly through the cache - the same thing will then work with direct regmap usage.
| |