lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC] fixing the UML failure root cause
On Wed, Oct 12, 2011 at 5:24 AM, Andrew Lutomirski <luto@mit.edu> wrote:
>
> So here's a different approach.  It's not perfect: it always blames
> SEGV_MAPERR instead of SEGV_ACCERR.  I implemented it for vgettimeofday
> but not the other two vsyscalls.
>
> What do you think of this approach?  If it seems good, I'll finish the
> patch and submit it.

I think the approach is valid, but you should *not* do this as some
kind of crazy byte-by-byte copy_to_user() emulation.

Do the "copy tz to user mode" as individual "put_user()" calls for
tv_sec/tv_usec/timezone. IOW, there are three words being written to
user mode, not "two memcpy's".

Other than that, there doesn't seem to be anything wrong.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-13 08:21    [W:0.115 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site