lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] pata_it8213: fix register naming used in it8213_set_piomode()
Date
Alan Cox wrote:

> On Thu, 13 Oct 2011 17:44:22 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH v2] pata_it8213: fix register naming used in it8213_set_piomode()
> >
> > Rename 'idetm_port' and 'idetm_data' variables to 'master_port'
> > and 'master_data' respectively to match register naming used in
> > it8213_set_dmamode() and in ata_piix.c.
>
> I do question this renaming. Surely we should reflect the names on the
> data sheets if anything ?

Please lets have some consistency in the driver first (same names used
in ->set_piomode and ->set_dmamode).. we can always do global rename
later if needed.



\
 
 \ /
  Last update: 2011-10-13 18:13    [from the cache]
©2003-2011 Jasper Spaans