lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems
Date
From

> Kumar Gala wrote:
> >>> >> + phys_addr_t addr;
> >> >
> >> > Please add a comment here saying:
> >> >
> >> > 1) That 'addr' can be a virtual or physical address
> > The code and everything else makes that clear
>
> I'm sorry, but I have to strongly disagree here. It is *NOT*
> clear that a variable of type 'phys_addr_t' can hold something
> that is not a physical address.

Since there is a discriminating field, could a union be used?
At a guess the type of the address is constrained between
produces and consumer??

David




\
 
 \ /
  Last update: 2011-10-13 17:47    [W:0.043 / U:13.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site