Messages in this thread | | | Date | Thu, 13 Oct 2011 11:26:03 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH 7/9] ASoC: da7210: Add support for ALC and Noise suppression |
| |
On Thu, Oct 13, 2011 at 02:45:45PM +0530, Ashish Chavan wrote: > On Wed, 2011-10-12 at 16:04 +0100, Mark Brown wrote:
> > No, don't go peering directly into the register cache. This is going to > > explode if the board configures a different cache style and means you > > can't change the cache type later. Just read the register and trust > > that the cache will do something sane.
> Will update the code to directly read the register. I thought of saving > some io bandwidth and if I remember correctly, I saw few exiting drivers > doing this.
The whole point of having the register cache is that reads don't result in any actual I/O, if there's any I/O happening we need to fix the register cache code.
| |