Messages in this thread | | | Subject | Re: [PATCH RFC V4 04/10] x86/jump_label: drop arch_jump_label_text_poke_early() | From | Peter Zijlstra <> | Date | Thu, 13 Oct 2011 12:15:52 +0200 |
| |
On Wed, 2011-10-12 at 17:08 -0700, Jeremy Fitzhardinge wrote: > From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > It is no longer used. > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > Acked-by: Jason Baron <jbaron@redhat.com> > --- > arch/x86/kernel/jump_label.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c > index 3fee346..2ad0298 100644 > --- a/arch/x86/kernel/jump_label.c > +++ b/arch/x86/kernel/jump_label.c > @@ -42,10 +42,4 @@ void arch_jump_label_transform(struct jump_entry *entry, > put_online_cpus(); > } > > -void arch_jump_label_text_poke_early(jump_label_t addr) > -{ > - text_poke_early((void *)addr, ideal_nops[NOP_ATOMIC5], > - JUMP_LABEL_NOP_SIZE); > -} > - > #endif
This was the (first and) last usage site outside of alternative.c, so at the very least we should clean up arch/x86/include/asm/alternative.h.
However, since stop_machine now works early, is there any reason to keep text_poke_early() itself? Shouldn't we also convert alternative.c's use of text_poke_early and simply kill the thing off?
| |