lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip
On Wed, 12 Oct 2011, Nobuhiro Iwamatsu wrote:

> Although some functions of of irq generic-chip can be used,
> since EXPORT_SYMBOL is not specified, it cannot use.

This does not make sense. In which context they can't be used?

> This is revised that EXPORT_SYMBOL can be added and referred
> to in functions.

EXPORT_SYMBOL_GPL if at all please.

And I'd rather avoid the exports, except those

> +EXPORT_SYMBOL(irq_alloc_generic_chip);
> +EXPORT_SYMBOL(irq_setup_generic_chip);
> +EXPORT_SYMBOL(irq_setup_alt_chip);
> +EXPORT_SYMBOL(irq_remove_generic_chip);

which are really necessary. To gain access to the various helper
functions we're better off to create a data structure with function
pointers.

struct irq_gc_functions {
void (* irq_gc_noop)(...);
...
};

Instantiate this structure in kernel/irq/generic-chip.c, statically
initialize it with pointers to those helper functions and export that
data structure. That's way more efficient than having the overhead of
the symbol export for each of the functions.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-10-12 11:27    [W:0.031 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site