lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink
    From
    Eric,
    I think it would be useful to expose the values this way.
    I shall make the changes to add TCLASS for ipv6 in the description.

    Regarding the TIME_WAIT state, I think it would be better of not
    exposing the values because there would hardly be anything to transmit
    during this time.

    Thanks,
    Murali

    On Tue, Oct 11, 2011 at 7:48 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
    > Le mardi 11 octobre 2011 à 18:28 -0700, Muraliraja Muniraju a écrit :
    >> From: Murali Raja <muralira@google.com>
    >>
    >> This patch exposes the tos value for the TCP sockets when the TOS flag
    >> is requested in the ext_flags for the inet_diag request. This would mainly be
    >> used to expose TOS values for both for TCP and UDP sockets. Currently it is
    >> supported for TCP. When netlink support for UDP would be added the support
    >> to expose the TOS values would alse be done.
    >>
    >
    > You could mention TCLASS support for IPv6
    >
    >> Signed-off-by: Murali Raja <muralira@google.com>
    >> ---
    >> Changelog since v2:
    >> - Adding support for IPV6 class and using right API's
    >> Changelog since v1:
    >> - Removing reserved field
    >>
    >>  include/linux/inet_diag.h |    9 ++++++++-
    >>  net/ipv4/inet_diag.c      |    5 +++++
    >>  2 files changed, 13 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
    >> index bc8c490..e36093d 100644
    >> --- a/include/linux/inet_diag.h
    >> +++ b/include/linux/inet_diag.h
    >> @@ -97,9 +97,10 @@ enum {
    >>       INET_DIAG_INFO,
    >>       INET_DIAG_VEGASINFO,
    >>       INET_DIAG_CONG,
    >> +     INET_DIAG_TOS,
    >>  };
    >>
    >> -#define INET_DIAG_MAX INET_DIAG_CONG
    >> +#define INET_DIAG_MAX INET_DIAG_TOS
    >>
    >>
    >>  /* INET_DIAG_MEM */
    >> @@ -120,6 +121,12 @@ struct tcpvegas_info {
    >>       __u32   tcpv_minrtt;
    >>  };
    >>
    >> +/* INET_DIAG_TOS */
    >> +
    >> +struct inet_diag_tos {
    >> +     __u8    idiag_tos;
    >> +};
    >
    > Are you sure its still needed ?
    >
    > I am now wondering what is done in TIME_WAIT state.
    >
    >
    >



    --
    Thanks,
    Murali
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-12 06:19    [W:0.028 / U:121.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site