lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cy82c693: fix PCI device selection
From
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Wed, 12 Oct 2011 16:52:10 +0200

> David Miller wrote:
>
>> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>> Date: Tue, 11 Oct 2011 19:37:32 +0200
>>
>> > While at it remove redundant pci_get_slot() call as cy82c693_init_one()
>> > already takes care of keeping the reference on the second port's PCI
>> > device.
>>
>> Please do not submit unrelated changes with a bug fix, and as IDE is
>> in long-term maintainence I would not accept a risky refinement like
>> this anyways.
>
> Removed code is just bogus, we cannot fail in ->set_pio_mode method.
>
> Please take a look at the code:
>
> - /* select primary or secondary channel */
> - if (hwif->index > 0) { /* drive is on the secondary channel */
> - dev = pci_get_slot(dev->bus, dev->devfn+1);
> - if (!dev) {
> - printk(KERN_ERR "%s: tune_drive: "
> - "Cannot find secondary interface!\n",
> - drive->name);
> - return;
> - }
> - }
>
> Please apply the patch,

Sorry, I will not do that, please respin the patch with the unrelated
pieces removed. I don't care how obvious it is to you.

The IDE layer is not a place for refinements or simplifications any
longer, I'm sorry if that isn't clear to you.




\
 
 \ /
  Last update: 2011-10-12 21:05    [W:0.123 / U:31.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site