lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] threadgroup: extend threadgroup_lock() to cover exit and exec
On Wed, Oct 12, 2011 at 08:29:05PM +0200, Oleg Nesterov wrote:
> On 10/12, Ben Blum wrote:
> >
> > On Wed, Oct 12, 2011 at 07:51:04PM +0200, Oleg Nesterov wrote:
> > >
> > > > Also, it makes the mechanism unnecessarily cgroup-specific without
> > > > gaining much if anything.
> > >
> > > Yes! And _personally_ I think it should be cgroup-specific, that is
> > > why I dislike the very fact do_exit() uses it directly. To me it would
> > > be cleaner to shift it into cgroup hooks. Yes, sure, this is subjective.
> >
> > In the fork path, threadgroup_fork_read_...() is also called directly,
> > not through cgroups. Would that change too?
>
> Well, if you ask me, I'd prefer to move lock/unlock into
> cgroup_fork/cgroup_post_fork ;) Although the error path plays with it
> too. But this is minor.
>
> > > In fact I still hope we can kill this sem altogether, but so far I have
> > > no idea how we can do this. We do need the new per-process lock to
> > > protect (in particular) ->thread_group. It is quite possible that it
> > > should be rw_semaphore. But in this case we down_write(), not _read
> > > in exit/fork paths, and its scope should be small.
> >
> > I'm confused - taking a big rwsem for writing in the fork/exit paths?
>
> Yes, we need the new lock to avoid tasklist_lock.

To avoid tasklist_lock in the cgroup path, or in the fork/exit path?

I'm not sure if "avoiding tasklist_lock" should be our goal. The only
real problem as I see it is that ss->attach() can still race exec *if*
it wants to iterate over the whole thread_group, since the "leader"
passed in might not be the leader anymore.

Unless this is just all about trying to avoid taking a global lock?
(which in cgroups we agreed could be done with the sighand lock instead)

As for the ss->attach problem again: Ummm, I have an idea. Why don't we
just alter the ss->attach() interface to pass in the flex_array of
task_structs that are being moved? The flex_array is how we solved the
problem of "having to check thread_group_leader() everywhere before the
commit point" nastiness. No need for the fork_lock to be in the exit
path at all; its current place in the fork path would suffice for this.

Thoughts?

-- Ben

>
> > The point here is that even though fork/exit modify thread_group, they
> > are logical "readers"
>
> Yes I see. And this is one of the reasons why we can't use this lock
> for above.
>
> Oleg.
>
>


\
 
 \ /
  Last update: 2011-10-12 20:51    [W:0.037 / U:5.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site