Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] pata_cs5520: remove incorrect warning message | Date | Wed, 12 Oct 2011 17:27:46 +0200 |
| |
Alan Cox wrote:
> On Tue, 11 Oct 2011 20:00:44 +0200 > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Subject: [PATCH] pata_cs5520: remove incorrect warning message > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Nothing incorrect about it. It's rather useful information for debugging > CS5520 problems. Users should never see it - and I've not seen it > occuring on any standard VSA releases. > > Do you have any examples of it confusing users or even showing up ?
This driver dooen't even use DMA mode so warning about forcing the setting may be puzzling. In addition we do the same thing cs5520_reinit_one() but without warning the user this time. Thus removal of the warning makes it easier for *_reinit_one() replacement by ->init_host method later (patch is ready for this).
| |