lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2 v2] pch_dma: Reduce wasting memory
From
Date
On Wed, 2011-10-12 at 09:38 +0900, Tomoya MORINAGA wrote:
> nr_channels is defined in "struct pch_dma".
> and struct pch_dma_chan is defined in "struct pch_dma".
> So, "sizeof(struct pch_dma_chan) * nr_channels" is unnecessary.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
> ---
> v2: Change sizeof(struct pch_dma) to sizeof(*pd)
> ---
> drivers/dma/pch_dma.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 326fedc..58b215c 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -997,8 +997,7 @@ static int __devinit pch_dma_probe(struct pci_dev *pdev,
> int i;
>
> nr_channels = id->driver_data;
> - pd = kzalloc(sizeof(struct pch_dma)+
> - sizeof(struct pch_dma_chan) * nr_channels, GFP_KERNEL);
> + pd = kzalloc(sizeof(*pd), GFP_KERNEL);
> if (!pd)
> return -ENOMEM;
>
Applied thanks.

Although we can further optimize by removing static array and
dynamically allocate channel structures based on nr_channels, that can
be taken further separately.

--
~Vinod



\
 
 \ /
  Last update: 2011-10-12 07:41    [W:0.034 / U:19.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site